On 30/05/2006, at 5:07 AM, Lars T. Mikkelsen wrote: > On Mon, May 29, 2006 at 12:37:11AM +0200, Stian B. Barmen wrote: >> I am sorry to say that one of my users this morning reported this >> problem to me again. He said that he tried to reset his password >> and for >> a few hours the problem was gone. This evening the problem was >> back and >> the same message about user logged in elsewere started up again. > > Okay, I think I figured out what's going wrong here. My Gaim went nuts > this morning and crashed numerous times - and when I checked my PyMSNt > log, I also noticed the tracebacks again. I found out, that I'm > able to > reproduce the issue by signing off shortly after signing on. > > When signing on, a msnw.NotificationClient is created by a > msnw.MSNConnection. However, msnw.MSNConnection.notificationClient > isn't > set until msnw.MSNConnection._notificationClientReady() is called. If > the user logs out before that happens, > msnw.NotificationClient.logOut() > won't get called from msnw.MSNConnection.logOut(). So we'll now have a > stray, reconnecting NotificationClient, that has lost its > MSNConnection > - and it will continue to connect and lose its connection infinitely. > > I hope this description makes sense. :-) > > I don't actually know a proper fix, but I've attached a patch that I > think will at least workaround the issue. Another option is to > downgrade > to SVN r139 - that's the last revision that didn't have the > reconnecting > NotificationClient. > > Best regards, > Lars > <workaround.patch>
Thanks Lars! I've committed a fix to SVN. Hopefully this will solve the problem once & for all :) --- James
