On Sun, 06 Jan 2013 18:53:13 +0100
Christoph Zwerschke <[email protected]> wrote:
> As you already noticed, I have refactored and cleaned up pgnotify and 
> the corresponding tests a bit. They run also much faster now. The
> code is still pretty much compatible to the original pgnotify, and
> still uses the same name. One thing I added besides the payload bit
> is a "listening" attribute that allows checking the current status of
> the listener from outside and a close() method that will close the 
> corresponding db connection. In a next step I would like to rename
> the whole thing, e.g. the class could be "WhenNotified" and the
> method could be DB.when_notified(). What do you think?

The only problem I see is existing code.  Right now all they have to do
is drop the pgnotify import and code should still be correct.  If you
want to change it perhaps add pgnotify wrappers that spit out a
deprecation notice and then call the new name.  Then we can drop the
old name in 5.0.

On the other hand, we don't have pgnotify now so maybe it is OK to make
them change their code now.

-- 
D'Arcy J.M. Cain
PyGreSQL Development Group
http://www.PyGreSQL.org IM:[email protected]
_______________________________________________
PyGreSQL mailing list
[email protected]
https://mail.vex.net/mailman/listinfo.cgi/pygresql

Reply via email to