On Sat, 31 Jan 2015 13:00:23 -0700
Brad Davis <[email protected]> wrote:
> Here are patches for a BETA port of PyGreSQL to Python 3.2. I don't
Thanks. Sorry to be so long getting back but it has been a very busy
time for me. I am going to start looking through the code now. I will
make comments as I see things.
> I haven't fully tested it yet. I only needed Unicode string queries
Have you tried the unit tests?
> Things left to do:
> 1. Fix setup.py to handle 2.x and 3.x
> 2. Fix Python code to handle both 2.x and 3.x (or fix setup.py to
> select the correct files to install)
> 3. Test all the functionality.
>
> Brad Davis
> P.S. Let me know of this doesn't come through correctly.
I would prefer unified diffs. I find them easier to read. Many open
source projects require that. All you have to do is add the "-u"
option to your diff command.
> ! elif isinstance(self.debug, collections.Callable):
Note that callable() has been added back in 3.2. We can probably leave
that as it was.
> ! if isinstance(d, basestring):
I wonder if we could just add this at the top if running 3.x:
class basestring(str): pass
> *** 697,702 ****
> # If run as script, print some information:
>
> if __name__ == '__main__':
> ! print('PyGreSQL version', version)
> print('')
> print(__doc__)
> --- 696,701 ----
> # If run as script, print some information:
>
> if __name__ == '__main__':
> ! print(('PyGreSQL version', version))
> print('')
> print(__doc__)
Hmm. I wonder if the original is what we intended in the first place.
Maybe we wanted;
print('PyGreSQL version %s' % version)
I am going to check further on this and possibly apply anything that
will also work in 2.x.
--
D'Arcy J.M. Cain
PyGreSQL Development Group
http://www.PyGreSQL.org IM:[email protected]
_______________________________________________
PyGreSQL mailing list
[email protected]
https://mail.vex.net/mailman/listinfo.cgi/pygresql
