On Tue, 17 Nov 2015 21:48:19 +0100 Christoph Zwerschke <[email protected]> wrote: > I've already started working on test_pg, better let me care for that > so we don't interfere.
I found errors in the TEST_PyGreSQL_classic_connection.py run. The diff at the bottom of this message fixed some of them but I am not sure if they should be committed. In any case I don't want to bump into your work so I will leave you to decide. > You can continue to work on the trunk. I'll create the 4.x branch at > the point where you departed, and make sure the tests run at that > point, then I'll merge the new tests back to the trunk. Or perhaps you are still working on it. I will continue to suggest changes as I see them and let you work out what gets committed and when. > I wonder if we should move to GitHub, and use Travis for testing? > This would allow us to test with various Python and Postgres versions: > http://docs.travis-ci.com/user/using-postgresql/ Does that mean moving to git? I really think that Subversion works for us. Also, didn't some repository site just go away suddenly leaving everyone to scramble for a new location? Index: TEST_PyGreSQL_classic_connection.py =================================================================== --- TEST_PyGreSQL_classic_connection.py (revision 541) +++ TEST_PyGreSQL_classic_connection.py (working copy) @@ -73,7 +73,7 @@ pass def testAllConnectAttributes(self): - attributes = '''db error host options port + attributes = '''__doc__ db error host options port protocol_version server_version status tty user'''.split() connection_attributes = [a for a in dir(self.connection) if not callable(eval("self.connection." + a))] @@ -80,9 +80,11 @@ self.assertEqual(attributes, connection_attributes) def testAllConnectMethods(self): - methods = '''cancel close endcopy - escape_bytea escape_identifier escape_literal escape_string - fileno get_notice_receiver getline getlo getnotify + methods = '''__class__ __delattr__ __format__ __getattribute__ + __hash__ __init__ __new__ __reduce__ __reduce_ex__ __repr__ + __setattr__ __sizeof__ __str__ __subclasshook__ cancel close + endcopy escape_bytea escape_identifier escape_literal + escape_string fileno get_notice_receiver getline getlo getnotify inserttable locreate loimport parameter putline query reset set_notice_receiver source transaction'''.split() connection_methods = [a for a in dir(self.connection) @@ -97,8 +99,7 @@ self.assertTrue(not error or 'krb5_' in error) def testAttributeHost(self): - def_host = 'localhost' - self.assertEqual(self.connection.host, def_host) + self.assertEqual(self.connection.host, dbhost) def testAttributeOptions(self): -- D'Arcy J.M. Cain PyGreSQL Development Group http://www.PyGreSQL.org IM:[email protected] _______________________________________________ PyGreSQL mailing list [email protected] https://mail.vex.net/mailman/listinfo.cgi/pygresql
