On 11/9/2007 11:33 AM, Anton wrote: >> There are also some other problems here and there to fix to do a clean >> patch. I see that class NonELFEXE in Build.py is probably a little >> bitrot. From a quick glance, it has duplicated code to compose the >> bootloader file name, but should instead share that code with ELFEXE. >> >> After that, one could also add an option to Makespec.py to use >> NonELFEXE, so that NonELFEXE basically becomes an user-level feature, >> instead of only a configuration option. And maybe rename NonELFEXE to >> soemthing more clear ;) > > If this was done, would you see any reason why it would be preferable > to append the PKG to the exe in a one-directory setup? one-file is > clear. I mean, should this external PKG (non elf exe) be the default > for one-dir setups if this was implemented?
I don't have a strong opinion about the default. I had a quick discussion with some colleagues about this, and they didn't find it compelling as well. > I did not modify Build.py for my test. I just used a standard one I'm -1 about adding it as an option to Makespec.py. It really feels like an implementation detail which isn't so importanto to Makespec's users. And: Real PyInstaller Users Don't Use Makespec(TM). > dir .spec, and then used the outN.pkg and the plain bootloader without > anything appended. If testing shows that all this solves the problems > I have seen on windows, would you be interested in neater patches to > winmain.c and Build.py along the lines you suggested. Yes, that'd be great! I'd also appreciate if you took some time to update the manual about it, to make sure the information is up-to-date. I was thinking about writing a wiki page about advanced PyInstaller tricks/setups like yours. -- Giovanni Bajo --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "PyInstaller" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/PyInstaller?hl=en -~----------~----~----~----~------~----~------~--~---
