On 8/21/2007 2:46 AM, Greg Copeland wrote:

> Since the current hook-xml.py file is broken, I quickly threw together
> a proper implementation.  This version attempts to do away with the
> process spawning nonsense which in turn spawned a platform specific
> bug, which in turn is still broken for Linux (throws exceptions for
> me).  This version is faster and platform agnostic while being easier
> to read and therefore maintain.  Please add to SVN.  It works for me
> but I only tested it on Linux.  I see no reason it will fail on MSWin
> based platforms.

 >     [...]
>     # caring for platform details as python already addresses it.  -gc
>     import xml as xxxxxml

Point is, hooks shouldn't import anything. That's a basic rule in 
PyInstaller; libraries can have nasty side effects on import. Of course, 
it might be noted that PyXML doesn't have any of those so its import is 
safe...

The current version is nonsense, agreed, and it's broken, agreed too. 
But I'd rather have a fix which doesn't involve importing in the current 
Python interpreter.
-- 
Giovanni Bajo


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"PyInstaller" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/PyInstaller?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to