> Thank you for applying my patches. I am running tests on AIX again to
> verify everything still works.

It seems that revision 1822 broke AIX support.

These changes in buildtests/runtests.py is the cause:

 # Run the test in a clean environment to make sure they're
 # really self-contained
-path = os.environ["PATH"]
-del os.environ["PATH"]
+path = compat.getenv("PATH")
+compat.unsetenv("PATH")

The problem is that os.unsetenv() does not exist on AIX, so
runtests.py fails:


#################### EXECUTING TEST basic/test_1 ####################

Traceback (most recent call last):
  File "./runtests.py", line 375, in <module>
    runtests(tests, run_executable=not opts.no_run,
verbose=opts.verbose)
  File "./runtests.py", line 236, in runtests
    res_tmp = test_exe(exe[5:], testdir)
  File "./runtests.py", line 289, in test_exe
    compat.unsetenv("PATH")
  File "/data/maconomy/mgd/pyinstaller/pyinstaller-aix-trunk-patches-
test/PyInstaller/compat.py", line 108, in unsetenv
    os.unsetenv(name)
AttributeError: 'module' object has no attribute 'unsetenv'


Another problem is that this code is not really correct (I guess):

This code
  del os.environ["PATH"]
deletes PATH from environ _and_ unsets the environment variable if
supported by the platform (as described in the pydocs).

The new code
  compat.unsetenv("PATH")
only unsets the variable (or crashes if "unsetenv" is not supported on
the platform), but it leaves behind PATH in os.environ thus creating
an inconsistency between Python's idea of the environment and the real
OS environment.

(Read here http://docs.python.org/library/os.html and look for the
section on os.environ.)

/Martin

-- 
You received this message because you are subscribed to the Google Groups 
"PyInstaller" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/pyinstaller?hl=en.

Reply via email to