On Thursday 08 of October 2015 15:10:36 David Cortesi wrote: > Six of the hook-xml* files assign values to an attrs global, as if this had > some meaning. Does a global attrs mean anything in the current hook API?
In the current hook API it means nothing. There is just a TODO in the code. I think it was broken even in the previous version 2.1. Even if it is in the six old hook-xml* files it has no effect - legacy hook code. We should revisit the usecase for attrs: https://github.com/pyinstaller/pyinstaller/issues/1592 We should create some tests for the 'xml' modules and cleanup the hook-xml* files because these are really old hooks. https://github.com/pyinstaller/pyinstaller/issues/1591 -- Martin Zibricky -- You received this message because you are subscribed to the Google Groups "PyInstaller" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/pyinstaller. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: This is a digitally signed message part.
