On Saturday 10 of October 2015 14:16:58 davecortesi wrote: > I'm working on the "About Hooks" manual section. > > In large part it is documentation of the things a hook can import from > compat or from utils.hooks. > > As of now I am leaning toward NOT documenting the following items: > > compat.exec_command* (three methods in all).
Yes, do not document these for hook usage. > > It seems to me that the utils.hooks.exec_* and utils_hooks.eval_* methods > are sufficient. Does anyone know of a use case where a hook would require > compat.exec_command() and could not use utils.hooks.exec_statement() > instead? In theory I could think of an hook that requires some output of any external shell command. Being a wrapper for 'subprocess'. hook-PyQt5.WebEngineWidgets.py uses compat.exec_command. But let's rather not document it when we are not sure. > > utils.hooks.exec_script() and eval_script(). > > The only use case I can think of is if you are creating a family of related > hooks and you could factor out some very complex calculation to a script in > utils/hooks/subproc. Which seems unlikely to me. Or does these have some > use in the special pre-safe* or pre-find* hooks? Yes, do not document these too. I don't know about pre-safe or pre-find usage. Hardmut or someone else would have to speak out. > > opengl_arrays_modules() > > As noted in the code, this is only used in one hook and will be moved to > that hook. Yes, not document. > > All the Qt4 and Qt5 special functions such as qt5_qml_dir(). > > These are only used from the PyQt (and PySide) hooks which already exist. Yes, also not document. -- Martin Zibricky -- You received this message because you are subscribed to the Google Groups "PyInstaller" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/pyinstaller. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: This is a digitally signed message part.
