On Thu, 29 Dec 2011 10:04:39 +0000, phil.charlesworth-AT-physics.org wrote:
> On Wed, 28 Dec 2011 20:09:42 +0000, lkcl luke <luke.leighton-AT-gmail.com> > wrote: > > > On Wed, Dec 28, 2011 at 4:25 PM, <phil.charleswo...@physics.org> wrote: > > > > > > > Luke, > > > I have posted a more detailed description of what I have found in GWT > > > as > > > a further comment on Issue 537, with copies of the relevant files. I ask a > > > question there about how to interpret code that appears to be commented > > > out, > > > i.e. is it really commented out or is it to be taken as literal > > > Javascript? > > > > http://code.google.com/p/pyjamas/issues/detail?id=537 > > > > literal javascript. > > > > > If, as I suspect, the second of those alternatives is correct, to be > > > compatible with the GWT code, the safari override for Focus.py needs to > > > have createFocusable() removed and the blur and focus functions need to > > > act > > > on the element, not on its first child. > > > > > > I have incorporated both those modification in my local copy of the code > > > and > > > my test application now throws no Javascript errors and operates > > > correctly. > > > > ok, but they've moved stuff about. the other implementations of > > Focus will thus be affected. > > > > > If we can agree on the modifications needed, I will provide a diff. > > > > ok it needs a bit more investigation - can you grab the other > > FocusImpl*.java files and add them to the issue, for analysis as well? > > > > also Focus.java although a link to its location in the svn tree would > > do just as well :) > > > > l. > > L, > Additional GWT files posted in a comment to Issue 537 as requested. > P. L. I read your latest comment on Issue 537. I am assuming you are going to fix this when you get time, because you obviously understand it better than I do, but I'm happy to help further if I can. Regards, Phil
