I think the if statement should be removed. Otherwise this function will silently fail on elements that do not have a Placeholder. In all other cases you get an error as you should when setting an invalid attribute this should work the same way.
- lex On Sun, Jan 22, 2012 at 4:51 AM, lkcl luke <[email protected]> wrote: > On Sun, Jan 22, 2012 at 9:02 AM, Vsevolod Fedorov > <[email protected]> wrote: >> Hello! >> >> I submitted a patch for TextBox placeholder: >> http://code.google.com/p/pyjamas/issues/detail?id=678 >> >> please, include it to pyjamas. >> Thank you! > > yep, done. please double-check. please also remember to add > yourself to the copyright file, otherwise i have to do it. > > i just love the list of names in the copyright file. i think some > day we need an audio file - a roll of honour - of all the people > who've contributed to pyjamas. the only problem is that it would be > necessary to have them done by the people who actually contributed, > because i sure as hell can't pronounce most of them :) > > l.
