Hi, Lex! I think the idea for pyjamas is to handle differences between web browsers by itself, not to leave this to pyjamas user. I agree that simple 'if' statement is not that good for this case, but I am not familiar with pyjamas enough to think of better solution. Do you use this placeholder in you project? How you deal with different browsers/pyjd yourself?
Seva On 01/22/12 21:13, Lex Berezhny wrote: > It appears there were two things done with this patch: > > 1. setIntAttribute was changed to setAttribute > 2. the set operation was wrapped in an if statement > > I think the first change makes sense since a placeholder is a string. > > The second one I think should be done in your own app. It's not > pyjamas fault that webkit doesn't support this yet. I think adding > this exception into the core library produces inconsistent behavior. > All other setAttribute operations throw an error if the attribute does > not exist but now setPlaceholder will silently fail. I think that's > really bad for API consistency. > > I can go ahead and remove the if statement. The solution would be for > Seva to check in his own app if setAttributej for placeholder would > fail or not before calling it. > > - lex > > On Sun, Jan 22, 2012 at 12:00 PM, lkcl luke<[email protected]> wrote: >> On Sun, Jan 22, 2012 at 3:26 PM, Lex Berezhny<[email protected]> wrote: >>> I think the if statement should be removed. Otherwise this function >>> will silently fail on elements that do not have a Placeholder. In all >>> other cases you get an error as you should when setting an invalid >>> attribute this should work the same way. >> can you work with vsevolod to resolve that? >> >> thanks lex. >> >> l.
