On Sun, Jan 22, 2012 at 5:13 PM, Lex Berezhny <[email protected]> wrote: > It appears there were two things done with this patch: > > 1. setIntAttribute was changed to setAttribute > 2. the set operation was wrapped in an if statement > > I think the first change makes sense since a placeholder is a string. > > The second one I think should be done in your own app. It's not > pyjamas fault that webkit doesn't support this yet. I think adding > this exception into the core library produces inconsistent behavior. > All other setAttribute operations throw an error if the attribute does > not exist but now setPlaceholder will silently fail. I think that's > really bad for API consistency. > > I can go ahead and remove the if statement. The solution would be for > Seva to check in his own app if setAttributej for placeholder would > fail or not before calling it.
ah no. i do not know what this placeholder is but if it is "not working" then it needs to be *made* to work. we cannot have people write code which goes "if all platforms except this one oh yes it doesn't quite do what's expected so we force everyone to code up exceptions to deal with it". l.
