Thanks, I'll remember that for next time. Looking forward to increased involvement with this project.
Kind regards, Robert lkcl luke <[email protected]> wrote: >On Sun, Jan 29, 2012 at 10:11 PM, Rob Peters ><[email protected]> wrote: > >> As per the previous email, please find attached a patch for the Parameter is >> Incorrect error. > > wha-hey! > >> This is my first time contributing to an open source project. If I need to >> do something different, please let me know. > > no that's good stuff peter. > >> There are a number of edits to the license file, but this is because my >> editor (Yay for Sublime Text 2!) automatically removed trailing whitespace. >> The edits are several trailing spaces it found. > > tsk tsk, good job those aren't part of the syntax or the text, eh? > > for future reference: the "normal" thing to do there is to do a >commit with a message "whitespace cleanup" or similar, and _then_ >commit a separate thingy. > > the rule for software development is: one commit <-> one purpose. if >you screw up, the granularity of "fixing the problem" will be to >remove the commit, *not* go hunting through vast amounts of code >looking for bits that aren't related. > > l.
