I've added a docstring to explain the (non-obvious) implementation. Hope that's okay---and doesn't create overhead in pyjs.
Peter 2012/3/26 lkcl luke <[email protected]>: > On Mon, Mar 26, 2012 at 10:21 PM, Michael Perkonigg <[email protected]> > wrote: >> On 26 Mar 2012 at 21:03, lkcl luke wrote: >> >>> On Mon, Mar 26, 2012 at 8:26 PM, Michael Perkonigg <[email protected]> >>> wrote: >>> > On 26 Mar 2012 at 10:57, Peter Bittner wrote: >>> > >>> >> Shouldn't we use the safe version of calculating the hypotenuse? >>> >> http://en.wikipedia.org/wiki/Hypot >>> > >>> > Sounds reasonable. I have a diff for that too, want me to raise a new >>> > issue, >>> > reopen the old one (if that's possible) or forget it? >>> >>> reopen. >> >> I attached the diff file (against HEAD!) but cannot change the state of the >> issue. >> http://code.google.com/p/pyjamas/issues/detail?id=705 > > ok - can you please in future do a version which takes into account > the fact that hypot already exists? in other words, you need to do a > "git pull". > > i now am forced to hand-edit the file which makes extra work for me. > > l.
