On Mon, Apr 2, 2012 at 12:16 PM, João Ventura
<[email protected]> wrote:
> Dear,
>
> I have a pyjamas application which I've wrote quite some time ago, which
> am now rewritting to handle more things on the client than on the
> server, which means that I have to pass some code from the server to the
> client.
>
> I'm starting to do that job, but there are some code which doesn't make
> sense on pyjs, which I would like to maintain on my files so it can be
> reused later in other cases. One example is "os.sep" which exists on
> "regular" python but not on pyjs os.py. But there is a os.path.sep. So,
> my question is, does it matter to the pyjs project if I "correct" and
> commit this?
go for it. it's actually just "from os.path import sep".
line 118 in /usr/lib/python2.6/os.py for example.
just literally copy that.
also remember to add yourself to the copyright file and also to the
header of the file you modify. Copyright (C) 2012 {you}
> I'm just asking this because, as I am not very familiar with git, I
> would have to learn it for commiting the fix. (Can someone provide me
> "git" (or gerrit?) links to instructions?)
git commit pyjs/src/pyjs/lib/os.py
then type in a message (an appropriate one!
then "git log" to find out the commit reference
then "git format-patch {foocommitjobbie}"
then attach the resultant files to a bugreport.
> Finally, I'm aware of the contributors "responsabilities".. :)
:)
goood
