Em 03-04-2012 16:24, lkcl luke escreveu:
> On Tue, Apr 3, 2012 at 2:52 PM, João Ventura<[email protected]>  
> wrote:
>> Hi Luke,
>>
>> thanks for your time. I've opened issue 708
>> (http://code.google.com/p/pyjamas/issues/detail?id=708) with the patch file.
>   *thumbs-up*.  ok i checked it over, it looks good.  i was a little
> surprised to see all those imports, but it turns out that yes, funnily
> enough, all those do actually exist in os.path ok actually pyjspath.py

Yeap, i tested all functions of os.path on os to see what of them were 
valid. I only kept the valid ones..

>   hmm... pyjspath.py really shouldn't be there because it's not part of
> the standard http://python.org distribution... *mumble* *mumble* where
> is pyjslib.py kept? that's in builtin... hmmm... pyjspath.py... should
> it be moved to there?  it's not exactly a builtin is it...
>
>   thoughts anyone?

Can't the code of pyjspath be copied as is to os.path? If os.path is 
just an alias fot pyjspath, there shouldn't be any problem on 
implementing that directly on os/path.py.

>> About commit write access, do I send you directly my "id_rsa.pub" file?
>   yyep.
>
>   i won't commit the patch for you, but will let you do it: as you've
> already done a "commit" locally, once the id_rsa.pub is installed, you
> will just need to do "git push" and everyone else can get at what
> you've done.
>
>   simple, huh?
>
>   l.

Yes, this git thing is indeed quite simple, when you get the hang of it.. :)
I'm going to send you my public key on another mail..


Thanks again,
João Ventura

Reply via email to