On 08/04/12 17:55, Peter Bittner wrote:
> I've added escaping to the AppendLogger. Now I hope it works fine for you.
>
> Peter
>
Thanks, Peter, that's fine. Phil
> 2012/4/8 lkcl luke<[email protected]>:
>
>> On Sun, Apr 8, 2012 at 3:41 PM, Phil Charlesworth
>> <[email protected]> wrote:
>>
>>
>>> Two points:
>>> 1. In a comment at the head of the __pyjamas__.py file it says
>>> # This is the gtk-dependent __pyjamas__ module.
>>> # In javascript this module is not needed, any imports of this module
>>> # are removed by the translator.
>>> so this doesn't look like a good place from which to import something.
>>>
>> hmmm... yeah.. *sigh* nobody tells me anything :) thank god it's
>> documented, and you're paying attention. i took a look at
>> translator_proto.py and yeah the __pyjamas__ module is a specific
>> exception for the compiler: it's actually a class instance (Pyjamas)
>> not a module! so yes we _could_ add an escape function to it but it
>> would have to be added to the translator_proto.py (and
>> translator_dict_*.py) Pyjamas class.
>>
>>
>>> 2. The pyjs version of the cgi module contains nothing but the the
>>> escape function, so importing it is not going to add any burden of
>>> unused code.
>>>
>> ahh ok :)
>>
>> maybe in the future that'll change, but if that's all there is then
>> hell, yeah, it's good.
>>
>> l.
>>
