Hi Will,
I've just incorporated your patches into CVS. As it's bang up to date
now, feel free to commit at will from now on :-)
If you could check it over before I do the release that would be great.
I made a few small mods, mainly to keep the API compatible with the
PyKaraoke GUI. I've made it possible to call the API with None for the
options object, so that other Python modules can import it and use it
without building an optparse object externally. I need to modify the KAR
and MPG players to support the new optparse options, but I'll leave that
for a future release.
The changes look fine; it runs fine on this box.
I'd like to add direct support for archives in pycdg.py as well (some players I've seen on Windows can directly support ZIP at least; if I drag in the stuff from cdg2bin that adds support for archives, we'll have 'em beat with ZIP, .tar.gz, and .tar.bz2 support :) BTW the archive support only uses zipfile and tarfile, both standard modules that ship with Python. The way current support is written, they're only imported when needed, so even on systems that don't support them for whatever reason, stuff will still work (you just have to extract it yourself).
But that can be in the next release; this looks good to go :)
--
Looking for something to read? Visit http://willfe.com/ ... it's easy, safe, and fun for the whole family!
