As a contrary view, 'map' is a logical name for it. Many people have a variable 'file', which also shadows a builtin. 'route_map' is oververbose, especially with long arguments. 'rmap' might be OK.
--Mike On Tue, Jul 7, 2009 at 12:09 PM, Kyle VanderBeek<[email protected]> wrote: > Yeah, that's generally considered bad form. I'm attaching a hg patch > to make the template change. > > (Cc'ing pylons-devel). > > On Tue, Jul 7, 2009 at 6:55 AM, afrotypa<[email protected]> wrote: >> >> This is probably not a biggie but in the make_map function (in >> routing.py), the following line reassigns the variable map to a new >> Mapper object for defining routes :- >> >> map = Mapper(directory=config['pylons.paths']['controllers'], >> always_scan=config['debug']) >> >> This hides the built-in python map function which is unlikely to be >> used in make_map anyhow. But it will perhaps be safer/clearer to use >> another name (such as route_map) for this mapper object to avoid any >> confusion. > > -- > Kyle. > www.kylev.com > > > > -- Mike Orr <[email protected]> --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "pylons-discuss" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/pylons-discuss?hl=en -~----------~----~----~----~------~----~------~--~---
