> On Feb 12, 2018, at 09:33, Milo H. Fields III <mfie...@paladin-sys.com> wrote:
> 
> Andi,
> I have integrated PyLucene into a Visual Studio 2017 project space including 
> support for VS Python unit test fixture (AKA Test Explorer) and other IDE 
> platforms we use that instrument the unit test sets. This required some minor 
> tweaking to the test classes to support running the test suite independent of 
> a command line '__main__' (example below). 
> ----------------
> # PyLuceneTestCase.py  class PyLuceneTestCase
> #line 32 Method __init__ is:
>    def __init__(self, *args):
>        super(PyLuceneTestCase, self).__init__(*args)
> 
> # changed to:
>    def __init__(self, *args):
>        super(PyLuceneTestCase, self).__init__(*args)
>        if not lucene.getVMEnv():
>            lucene.initVM(vmargs=['-Djava.awt.headless=true'])
> -------------
> If you would be interesting in supporting the modifications to the unit test 
> fixtures I will submit them for review & test.

If you send me a patch, I’ll integrate it after checking that it doesn’t break 
the ‘usual’ way of running tests. As I don’t have access to Windows, I can’t 
test your fix for its intent nor verify that later changes won’t accidentally 
break it.

Thank you !

Andi..

> 
> v/r
> milo..
> 
>> -----Original Message-----
>> From: Andi Vajda [mailto:va...@apache.org]
>> Sent: Saturday, February 10, 2018 20:53
>> To: pylucene-dev@lucene.apache.org
>> Subject: Re: Unit Test Question - test_Collections.py
>> 
>> Yes, that looks like a copy/paste error indeed.
>> Thank you for reporting this.
>> 
>> Andi..
>> 
>>> On Feb 10, 2018, at 14:52, Milo H. Fields III <mfie...@paladin-sys.com>
>> wrote:
>>> 
>>> # pylucene-7.2.0\test3\test_Collections.py
>>> # line 109
>>> class Test_CollectionsBoolList(Test_CollectionsSetBase):
>>> 
>>>    def createTestSet(self):
>>>        return set([True,False])
>>> 
>>> # then at line 248
>>> class Test_CollectionsBoolList(Test_CollectionsListBase):
>>> 
>>>    def createTestList(self):
>>>        return [True,False]
>>> 
>>> 
>>> # Shouldn’t the first instance be named?
>>> class Test_CollectionsBoolSet(Test_CollectionsSetBase):
>>> 
>>> It causes issues for the python3.6.4 running on Windows 10
>>> 
>>> 
>>> 

Reply via email to