[ 
https://issues.apache.org/jira/browse/PYLUCENE-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494930#comment-17494930
 ] 

Petrus Hyvönen commented on PYLUCENE-62:
----------------------------------------

Hi,

Thanks for the update - looks much cleaner!

I would however really prefer that it searches both client and server 
directories, maybe if there is a need to select one could have that one as the 
first search choice? As it is now it gives an error if just "import jcc" on the 
python prompt (which I partly use as a test and could be unintuitive to the 
user). Default in my installation I'm having jvm in the server path.

Just for my future understanding, on the bullet 2, to keep it unconditional on 
machine - as the target wrapped library is compiled I thought this was a safe 
bet that it wouldn't be moved around?

The stuff in the SHARED  must be an error when I made the patch, I initially 
modified each case but went for a joint thing in the start instead.

 

something like in windows.py
{color:#d4d4d4} {color}{color:#c586c0}for{color}{color:#d4d4d4} 
{color}{color:#9cdcfe}location{color}{color:#d4d4d4} 
{color}{color:#c586c0}in{color}{color:#d4d4d4} 
(({color}{color:#ce9178}'bin'{color}{color:#d4d4d4}, 
{color}{color:#9cdcfe}client_or_server{color}{color:#d4d4d4}),{color}
{color:#d4d4d4}                         
({color}{color:#ce9178}'jre'{color}{color:#d4d4d4}, 
{color}{color:#ce9178}'bin'{color}{color:#d4d4d4}, 
{color}{color:#9cdcfe}client_or_server{color}{color:#d4d4d4}),{color}
{color:#d4d4d4} ({color}{color:#ce9178}'bin'{color}{color:#d4d4d4}, 'server' if 
{color}{color:#9cdcfe}client_or_server=='client' else 
'client'{color}{color:#d4d4d4}),{color}
{color:#d4d4d4}                         
({color}{color:#ce9178}'jre'{color}{color:#d4d4d4}, 
{color}{color:#ce9178}'bin'{color}{color:#d4d4d4}, 
{color}{color:#d4d4d4}'server' if 
{color}{color:#9cdcfe}client_or_server=='client' else 
'client'{color}{color:#d4d4d4}),{color}
{color:#d4d4d4}){color}
 

> Not finding jvm.dll on windows
> ------------------------------
>
>                 Key: PYLUCENE-62
>                 URL: https://issues.apache.org/jira/browse/PYLUCENE-62
>             Project: PyLucene
>          Issue Type: Bug
>            Reporter: Petrus Hyvönen
>            Priority: Major
>         Attachments: add_dll_win-1.patch, add_dll_win.patch, jvm_dll.diff
>
>
> On recent versions of Python, the dll's seems to require to be added via the 
> os.add_dll_directory() function.
>  
> Apparently something changed in Python 3.8 regarding this, "Python 3.8 
> changed the DLL resolution order 
> [https://docs.python.org/3/whatsnew/3.8.html#bpo-36085-whatsnew]";
> Thanks to:
> [https://github.com/conda-forge/python-feedstock/issues/552]
>  
> Proposed fix in a patch below. It can likely be rewritten in some more neat 
> way. :)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to