Tomasz Rybak <[email protected]> writes:
> Yes, it seems very interesting - thanks.
>
> But to worsen your mood a bit ( ;-) ) few tests fail.
> All tests run on Loveland (E-350). I started trying
> to deal with sorting, but decided to put all found
> errors into this email.
Doesn't worsen my mood one bit. I know that every bit of new
functionality (especially if it's as substantial as the new scan) has a
shake-out period ahead of it. The sooner the bug reports (and fixes)
start coming in, the better. :)
> test_array.py fails in line 1074 at
> sort = RadixSort(context, "int *ary", key_expr="ary[i]",
> sort_arg_names=["ary"])
>
> It seems like each RadixSort object tries to register its own
> (through _make_sort_scan_type) dtype without alias_ok - which
> raises RuntimeError("dtype '%s' already registered
> in compyte/dtypes.py line 50.
> I am not sure how to deal with that - whether to allow for
> aliases, have some sort of caching of RadixSort objects used
> to sort the same data type, or what. But IMO it is some sort
> of design decision.
>
> Similar case is in test_struct_reduce (line 738).
Hmm, I figured out that I had made a bit of a mess of the dtype
registration interface, redone in git.
> There is something wrong with test_scan (line 880).
> For n=1048577 (2**20+1) and ExclusiveScanKernel I got series of
> 26707443 (want: 3173493, got: 26707443, orig: 5)
> where it looks like first number (not in parentheses)
> is the same as the third one - while third should be
> equal to the second one.
> InclusiveKernel works OK for all sizes.
What device is this? Loveland?
> I also attach patch fixing some small problems with this test file.
> There are sometimes still some problems with
> "RuntimeError: clEnqueueNDRangeKernel failed: out of resources"
> even though I've added gc.collect() in tests - so I am not sure
> whether they all are required.
Thanks, applied. (They can't hurt.)
Andreas
_______________________________________________
PyOpenCL mailing list
[email protected]
http://lists.tiker.net/listinfo/pyopencl
