So I considered that (and right now, it has a show stopper bug which means we can’t start using it), but given (A) pinning to a specific version (which means we’re not going to be open to _new_ bugs or changes in behavior and (B) we’re still running flake8 (at least in my branch) but I think the risk is fairly low, particularly since its not a runtime library.
At worst we get crappy behavior and just disable it, we won’t have to revert the changes it has made since they still follow our flake8 requirements. > On Mar 22, 2018, at 4:14 PM, Ian Stapleton Cordasco > <graffatcolmin...@gmail.com> wrote: > > If you look at the issues I'm not sure it's presently stable enough for > Warehouse. There are quite a few bugs which is normal for such a new project > > Sent from my phone with my typo-happy thumbs. Please excuse my brevity > > On Mar 22, 2018 12:18, "Sumana Harihareswara" <s...@changeset.nyc > <mailto:s...@changeset.nyc>> wrote: > black <https://github.com/ambv/black <https://github.com/ambv/black>> is an > opinionated code formatter. > It is currently a pre-release in alpha. > > https://github.com/pypa/warehouse/pull/3367 > <https://github.com/pypa/warehouse/pull/3367> > > Donald would like to add black to our linter and format all Warehouse > code with black going forward. > > Comment on the pull request if you have thoughts. > -- > Sumana Harihareswara > Changeset Consulting > https://changeset.nyc <https://changeset.nyc/>