Author: Christian Tismer <tis...@stackless.com> Branch: Changeset: r53644:6f30b6fef5d1 Date: 2012-03-14 19:22 -0700 http://bitbucket.org/pypy/pypy/changeset/6f30b6fef5d1/
Log: a few more trivial changes for win64 diff --git a/pypy/rlib/rarithmetic.py b/pypy/rlib/rarithmetic.py --- a/pypy/rlib/rarithmetic.py +++ b/pypy/rlib/rarithmetic.py @@ -92,7 +92,10 @@ We therefore can no longer use the int type as it is, but need to use long everywhere. """ - + +# XXX returning int(n) should not be necessary and should be simply n. +# XXX TODO: replace all int(n) by long(n) and fix everything that breaks. +# XXX Then relax it and replace int(n) by n. def intmask(n): if isinstance(n, objectmodel.Symbolic): return n # assume Symbolics don't overflow diff --git a/pypy/rpython/lltypesystem/llmemory.py b/pypy/rpython/lltypesystem/llmemory.py --- a/pypy/rpython/lltypesystem/llmemory.py +++ b/pypy/rpython/lltypesystem/llmemory.py @@ -8,6 +8,8 @@ from pypy.rlib.objectmodel import Symbolic from pypy.rpython.lltypesystem import lltype from pypy.tool.uid import uid +from pypy.rlib.rarithmetic import is_valid_int + class AddressOffset(Symbolic): @@ -28,7 +30,7 @@ def __ge__(self, other): if self is other: return True - elif (isinstance(other, (int, long)) and other == 0 and + elif (is_valid_int(other) and other == 0 and self.known_nonneg()): return True else: @@ -58,7 +60,7 @@ return "<ItemOffset %r %r>" % (self.TYPE, self.repeat) def __mul__(self, other): - if not isinstance(other, int): + if not is_valid_int(other): return NotImplemented return ItemOffset(self.TYPE, self.repeat * other) diff --git a/pypy/translator/c/test/test_newgc.py b/pypy/translator/c/test/test_newgc.py --- a/pypy/translator/c/test/test_newgc.py +++ b/pypy/translator/c/test/test_newgc.py @@ -675,8 +675,8 @@ gc.collect() p_a1 = rffi.cast(rffi.VOIDPP, ll_args[0])[0] p_a2 = rffi.cast(rffi.VOIDPP, ll_args[1])[0] - a1 = rffi.cast(rffi.LONGP, p_a1)[0] - a2 = rffi.cast(rffi.LONGP, p_a2)[0] + a1 = rffi.cast(rffi.SIGNEDP, p_a1)[0] + a2 = rffi.cast(rffi.SIGNEDP, p_a2)[0] res = rffi.cast(rffi.INTP, ll_res) if a1 > a2: res[0] = rffi.cast(rffi.INT, 1) @@ -692,7 +692,7 @@ ptr = CallbackFuncPtr([ffi_type_pointer, ffi_type_pointer], ffi_type_sint, callback) - TP = rffi.CArray(rffi.LONG) + TP = rffi.CArray(lltype.Signed) to_sort = lltype.malloc(TP, 4, flavor='raw') to_sort[0] = 4 to_sort[1] = 3 @@ -700,7 +700,7 @@ to_sort[3] = 2 qsort.push_arg(rffi.cast(rffi.VOIDP, to_sort)) qsort.push_arg(rffi.cast(rffi.SIZE_T, 4)) - qsort.push_arg(rffi.cast(rffi.SIZE_T, rffi.sizeof(rffi.LONG))) + qsort.push_arg(rffi.cast(rffi.SIZE_T, rffi.sizeof(lltype.Signed))) qsort.push_arg(rffi.cast(rffi.VOIDP, ptr.ll_closure)) qsort.call(lltype.Void) result = [to_sort[i] for i in range(4)] == [1,2,3,4] @@ -1202,7 +1202,7 @@ def f(): from pypy.rpython.lltypesystem import lltype, rffi alist = [A() for i in range(50000)] - idarray = lltype.malloc(rffi.LONGP.TO, len(alist), flavor='raw') + idarray = lltype.malloc(rffi.SIGNEDP.TO, len(alist), flavor='raw') # Compute the id of all elements of the list. The goal is # to not allocate memory, so that if the GC needs memory to # remember the ids, it will trigger some collections itself _______________________________________________ pypy-commit mailing list pypy-commit@python.org http://mail.python.org/mailman/listinfo/pypy-commit