Author: Armin Rigo <ar...@tunes.org> Branch: exception-cannot-occur Changeset: r54139:2b2762fea668 Date: 2012-04-02 10:13 +0200 http://bitbucket.org/pypy/pypy/changeset/2b2762fea668/
Log: Disable a test that occasionally crashes because of ll2ctypes not being thread-safe at all. diff --git a/pypy/module/thread/test/test_ll_thread.py b/pypy/module/thread/test/test_ll_thread.py --- a/pypy/module/thread/test/test_ll_thread.py +++ b/pypy/module/thread/test/test_ll_thread.py @@ -66,7 +66,6 @@ def test_gc_locking(self): import time from pypy.rlib.objectmodel import invoke_around_extcall - from pypy.rlib.objectmodel import we_are_translated from pypy.rlib.debug import ll_assert class State: @@ -129,8 +128,6 @@ state.finished = 0 # the next line installs before_extcall() and after_extcall() # to be called automatically around external function calls. - # When not translated it does not work around time.sleep(), - # so we have to call them manually for this test. invoke_around_extcall(before_extcall, after_extcall) g(10, 1) @@ -142,13 +139,9 @@ willing_to_wait_more -= 1 done = len(state.answers) == expected - if not we_are_translated(): before_extcall() time.sleep(0.01) - if not we_are_translated(): after_extcall() - if not we_are_translated(): before_extcall() time.sleep(0.1) - if not we_are_translated(): after_extcall() return len(state.answers) @@ -160,12 +153,11 @@ answers = fn() assert answers == expected -class TestRunDirectly(AbstractThreadTests): - def getcompiled(self, f, argtypes): - return f - - def test_start_new_thread(self): - py.test.skip("deadlocks occasionally -- why???") +#class TestRunDirectly(AbstractThreadTests): +# def getcompiled(self, f, argtypes): +# return f +# These are disabled because they crash occasionally for bad reasons +# related to the fact that ll2ctypes is not at all thread-safe class TestUsingBoehm(AbstractThreadTests): gcpolicy = 'boehm' _______________________________________________ pypy-commit mailing list pypy-commit@python.org http://mail.python.org/mailman/listinfo/pypy-commit