Author: Armin Rigo <[email protected]>
Branch: 
Changeset: r70116:23f63b53184e
Date: 2014-03-20 15:55 +0100
http://bitbucket.org/pypy/pypy/changeset/23f63b53184e/

Log:    Kill some tests that are broken (they write a word at a random
        location in memory). Their usage is unclear.

diff --git a/rpython/jit/backend/x86/test/test_assembler.py 
b/rpython/jit/backend/x86/test/test_assembler.py
--- a/rpython/jit/backend/x86/test/test_assembler.py
+++ b/rpython/jit/backend/x86/test/test_assembler.py
@@ -55,9 +55,7 @@
         asm = cpu.assembler
         asm.setup_once()
         asm.setup(looptoken)
-        self.fm = X86FrameManager(0)
-        self.xrm = X86XMMRegisterManager(None, frame_manager=self.fm,
-                                         assembler=asm)
+        self.xrm = X86XMMRegisterManager(None, assembler=asm)
         callback(asm)
         asm.mc.RET()
         rawstart = asm.materialize_loop(looptoken)
@@ -75,29 +73,6 @@
         res = self.do_test(callback)
         assert res == 42
 
-    def test_push_stack(self):
-        def callback(asm):
-            loc = self.fm.frame_pos(5, INT)
-            asm.mc.SUB_ri(esp.value, 64)
-            asm.mov(imm(42), loc)
-            asm.regalloc_push(loc)
-            asm.regalloc_pop(eax)
-            asm.mc.ADD_ri(esp.value, 64)
-        res = self.do_test(callback)
-        assert res == 42
-
-    def test_pop_stack(self):
-        def callback(asm):
-            loc = self.fm.frame_pos(5, INT)
-            asm.mc.SUB_ri(esp.value, 64)
-            asm.mov(imm(42), edx)
-            asm.regalloc_push(edx)
-            asm.regalloc_pop(loc)
-            asm.mov(loc, eax)
-            asm.mc.ADD_ri(esp.value, 64)
-        res = self.do_test(callback)
-        assert res == 42
-
     def test_simple_xmm(self):
         def callback(asm):
             c = ConstFloat(longlong.getfloatstorage(-42.5))
@@ -108,33 +83,3 @@
             asm.mc.CVTTSD2SI(eax, xmm0)
         res = self.do_test(callback)
         assert res == -42
-
-    def test_push_stack_xmm(self):
-        def callback(asm):
-            c = ConstFloat(longlong.getfloatstorage(-42.5))
-            loc = self.xrm.convert_to_imm(c)
-            loc2 = self.fm.frame_pos(4, FLOAT)
-            asm.mc.SUB_ri(esp.value, 64)
-            asm.mov(loc, xmm5)
-            asm.mov(xmm5, loc2)
-            asm.regalloc_push(loc2)
-            asm.regalloc_pop(xmm0)
-            asm.mc.ADD_ri(esp.value, 64)
-            asm.mc.CVTTSD2SI(eax, xmm0)
-        res = self.do_test(callback)
-        assert res == -42
-
-    def test_pop_stack_xmm(self):
-        def callback(asm):
-            c = ConstFloat(longlong.getfloatstorage(-42.5))
-            loc = self.xrm.convert_to_imm(c)
-            loc2 = self.fm.frame_pos(4, FLOAT)
-            asm.mc.SUB_ri(esp.value, 64)
-            asm.mov(loc, xmm5)
-            asm.regalloc_push(xmm5)
-            asm.regalloc_pop(loc2)
-            asm.mov(loc2, xmm0)
-            asm.mc.ADD_ri(esp.value, 64)
-            asm.mc.CVTTSD2SI(eax, xmm0)
-        res = self.do_test(callback)
-        assert res == -42
_______________________________________________
pypy-commit mailing list
[email protected]
https://mail.python.org/mailman/listinfo/pypy-commit

Reply via email to