Author: Remi Meier <remi.me...@inf.ethz.ch>
Branch:
Changeset: r1343:0bb3f6af0fa4
Date: 2014-09-03 17:01 +0200
http://bitbucket.org/pypy/stmgc/changeset/0bb3f6af0fa4/
Log: add some XXXs
diff --git a/c8/stm/core.c b/c8/stm/core.c
--- a/c8/stm/core.c
+++ b/c8/stm/core.c
@@ -9,11 +9,14 @@
void _signal_handler(int sig, siginfo_t *siginfo, void *context)
{
+ /* make PROT_READWRITE again and validate */
- if (siginfo->si_addr == NULL) {
+ if (siginfo->si_addr == NULL) { /* actual segfault */
/* send to GDB */
kill(getpid(), SIGINT);
}
+ /* didn't know what to do with it: send to GDB */
+ kill(getpid(), SIGINT);
}
/* ############# commit log ############# */
@@ -104,6 +107,11 @@
stm_read(obj);
+ /* XXX: misses synchronisation with other write_barriers
+ on same page */
+ /* XXX: make backup copy */
+ /* XXX: privatize pages if necessary */
+
/* make other segments trap if accessing this object */
uintptr_t first_page = ((uintptr_t)obj) / 4096UL;
char *realobj;
@@ -215,6 +223,8 @@
_validate_and_add_to_commit_log();
+ /* XXX:discard backup copies */
+
s_mutex_lock();
assert(STM_SEGMENT->nursery_end == NURSERY_END);
_______________________________________________
pypy-commit mailing list
pypy-commit@python.org
https://mail.python.org/mailman/listinfo/pypy-commit
