Author: Armin Rigo <ar...@tunes.org>
Branch: cpyext-ext
Changeset: r82590:e2c600e30aa7
Date: 2016-02-27 16:52 +0100
http://bitbucket.org/pypy/pypy/changeset/e2c600e30aa7/
Log: Add an XXX about PyDict_GetItem() and IntMutableCells
diff --git a/pypy/module/cpyext/dictobject.py b/pypy/module/cpyext/dictobject.py
--- a/pypy/module/cpyext/dictobject.py
+++ b/pypy/module/cpyext/dictobject.py
@@ -23,6 +23,7 @@
# NOTE: this works so far because all our dict strategies store
# *values* as full objects, which stay alive as long as the dict is
# alive and not modified. So we can return a borrowed ref.
+ # XXX this is wrong with IntMutableCell. Hope it works...
return w_res
@cpython_api([PyObject, PyObject, PyObject], rffi.INT_real, error=-1)
@@ -62,6 +63,7 @@
# NOTE: this works so far because all our dict strategies store
# *values* as full objects, which stay alive as long as the dict is
# alive and not modified. So we can return a borrowed ref.
+ # XXX this is wrong with IntMutableCell. Hope it works...
return w_res
@cpython_api([PyObject, CONST_STRING], rffi.INT_real, error=-1)
_______________________________________________
pypy-commit mailing list
pypy-commit@python.org
https://mail.python.org/mailman/listinfo/pypy-commit
