Author: Richard Plangger <planri...@gmail.com> Branch: Changeset: r82953:253deb8fdde5 Date: 2016-03-11 07:19 +0100 http://bitbucket.org/pypy/pypy/changeset/253deb8fdde5/
Log: removed some dead code in the literal pool, removed some comments, unnecessary instruction diff --git a/rpython/jit/backend/zarch/assembler.py b/rpython/jit/backend/zarch/assembler.py --- a/rpython/jit/backend/zarch/assembler.py +++ b/rpython/jit/backend/zarch/assembler.py @@ -602,7 +602,7 @@ def patch_stack_checks(self, frame_depth): if frame_depth > 0x7fff: - raise JitFrameTooDeep # XXX + raise JitFrameTooDeep for traps_pos, jmp_target in self.frame_depth_to_patch: pmc = OverwritingBuilder(self.mc, traps_pos, 3) # patch 3 instructions as shown above @@ -1022,8 +1022,6 @@ self.mc.STMG(r.r6, r.r15, l.addr(-fpoff+6*WORD, r.SP)) self.mc.LARL(r.POOL, l.halfword(self.pool.pool_start - self.mc.get_relative_pos())) # f8 through f15 are saved registers (= non volatile) - # TODO it would be good to detect if any float is used in the loop - # and to skip this push/pop whenever no float operation occurs for i,reg in enumerate([r.f8, r.f9, r.f10, r.f11, r.f12, r.f13, r.f14, r.f15]): off = -fpoff + STD_FRAME_SIZE_IN_BYTES @@ -1082,8 +1080,6 @@ size = STD_FRAME_SIZE_IN_BYTES # f8 through f15 are saved registers (= non volatile) - # TODO it would be good to detect if any float is used in the loop - # and to skip this push/pop whenever no float operation occurs for i,reg in enumerate([r.f8, r.f9, r.f10, r.f11, r.f12, r.f13, r.f14, r.f15]): self.mc.LD(reg, l.addr(size + size + i*8, r.SP)) @@ -1369,8 +1365,6 @@ SIZE2SCALE = dict([(1<<_i, _i) for _i in range(32)]) def _multiply_by_constant(self, loc, multiply_by, scratch_loc): - # XXX should die together with _apply_scale() but can't because - # of emit_zero_array() and malloc_cond_varsize() at the moment assert loc.is_reg() if multiply_by == 1: return loc diff --git a/rpython/jit/backend/zarch/callbuilder.py b/rpython/jit/backend/zarch/callbuilder.py --- a/rpython/jit/backend/zarch/callbuilder.py +++ b/rpython/jit/backend/zarch/callbuilder.py @@ -203,7 +203,6 @@ self.mc.XGR(r.SCRATCH, r.SCRATCH) # zarch is sequentially consistent self.mc.STG(r.SCRATCH, l.addr(0, RFASTGILPTR)) - self.mc.BCR_rr(0xe, 0x0) def move_real_result_and_call_reacqgil_addr(self, fastgil): diff --git a/rpython/jit/backend/zarch/pool.py b/rpython/jit/backend/zarch/pool.py --- a/rpython/jit/backend/zarch/pool.py +++ b/rpython/jit/backend/zarch/pool.py @@ -128,30 +128,3 @@ # fast gil fastgil = rffi.cast(lltype.Signed, rgil.gil_fetch_fastgil()) self._ensure_value(fastgil, asm) - # TODO add more values that are loaded with load_imm - - # XXX def post_assemble(self, asm): - # XXX mc = asm.mc - # XXX pending_guard_tokens = asm.pending_guard_tokens - # XXX if self.size == 0: - # XXX return - # XXX for guard_token in pending_guard_tokens: - # XXX descr = guard_token.faildescr - # XXX offset = self.offset_descr[descr] - # XXX assert isinstance(offset, int) - # XXX assert offset >= 0 - # XXX assert guard_token._pool_offset != -1 - # XXX ptr = rffi.cast(lltype.Signed, guard_token.gcmap) - # XXX self._overwrite_64(mc, offset + RECOVERY_GCMAP_POOL_OFFSET, ptr) - - def _overwrite_64(self, mc, index, value): - index += self.pool_start - - mc.overwrite(index, chr(value >> 56 & 0xff)) - mc.overwrite(index+1, chr(value >> 48 & 0xff)) - mc.overwrite(index+2, chr(value >> 40 & 0xff)) - mc.overwrite(index+3, chr(value >> 32 & 0xff)) - mc.overwrite(index+4, chr(value >> 24 & 0xff)) - mc.overwrite(index+5, chr(value >> 16 & 0xff)) - mc.overwrite(index+6, chr(value >> 8 & 0xff)) - mc.overwrite(index+7, chr(value & 0xff)) _______________________________________________ pypy-commit mailing list pypy-commit@python.org https://mail.python.org/mailman/listinfo/pypy-commit