Author: Alex Gaynor <[email protected]>
Branch: alex_gaynor/remove-an-unneeded-call-into-openssl-th-1526429141011
Changeset: r94594:7a78467a6e72
Date: 2018-05-16 00:05 +0000
http://bitbucket.org/pypy/pypy/changeset/7a78467a6e72/

Log:    Remove an unneeded call into OpenSSL

        This call doesn't do anything, on every version of OpenSSL going
        back to forever the call to ERR_clear_error() calls ERR_get_state(),
        so it's always been a no-op.

        Same change for CPython: https://github.com/python/cpython/pull/6887

diff --git a/lib_pypy/_cffi_ssl/_stdssl/__init__.py 
b/lib_pypy/_cffi_ssl/_stdssl/__init__.py
--- a/lib_pypy/_cffi_ssl/_stdssl/__init__.py
+++ b/lib_pypy/_cffi_ssl/_stdssl/__init__.py
@@ -224,7 +224,6 @@
         if server_hostname:
             self.server_hostname = server_hostname.decode('idna', 'strict')
 
-        lib.ERR_get_state()
         lib.ERR_clear_error()
         self.ssl = ssl = ffi.gc(lib.SSL_new(ctx), lib.SSL_free)
 
_______________________________________________
pypy-commit mailing list
[email protected]
https://mail.python.org/mailman/listinfo/pypy-commit

Reply via email to