> I fixed it. Having a working "changes" tab would be cool, but not > immediately needed Thanks Maciej. It was just a case of adding the new branch parameter to the result dictionary, as you did in pypy/benchmarks/src/saveresults
I wanted to save you the time to look it up and change it but well, I couldn't. Regarding the broken changes table, it is obviously a related problem, together with not making the user having to browse through empty data. All of those issues are caused by only benchmarking some of the executables with one revision, and other with different revisions. Each can be more or less solved with a couple of lines of code, but it would introduce quite a bit of overhead, so we need to consider (test/benchmark) the possible solution carefully. Could you imagine implementing Antonio's suggestion?: Citing: >A quick workaround would be to force buildbot to update to a more specific >revision. E.g., "the highest revision of today at 00:00", or something like >this. This should ensure to have the same revision for all our >benchmarks/tests. Sounds good to me. Miquel 2011/7/20 Maciej Fijalkowski <fij...@gmail.com>: > On Wed, Jul 20, 2011 at 3:56 PM, Miquel Torres <tob...@googlemail.com> wrote: >> sorry, I have currently two busy days and couldn't look yet at it. >> Will do as soon as I can > > I fixed it. Having a working "changes" tab would be cool, but not > immediately needed > >> >> >> 2011/7/19 Antonio Cuni <anto.c...@gmail.com>: >>> On 18/07/11 22:36, Miquel Torres wrote: >>>> Ok, it is fixed now. >>>> >>>> AND branch support is in. Results saved with branch other than >>>> "default" will be available in the comparison view. Got to talk to >>>> fijal yet to see how we should benchmark branches... >>> >>> wow, all of this is very cool, thank you! >>> >>> However, there was a problem with the uploading of the results tonight :-/ >>> http://buildbot.pypy.org/builders/jit-benchmark-linux-x86-32/builds/791/steps/shell_7/logs/stdio >>> >>> Do you know what it could be? >>> >>> ciao, >>> Anto >>> >> _______________________________________________ >> pypy-dev mailing list >> pypy-dev@python.org >> http://mail.python.org/mailman/listinfo/pypy-dev >> > _______________________________________________ pypy-dev mailing list pypy-dev@python.org http://mail.python.org/mailman/listinfo/pypy-dev
