Sven,

If we use the overlapping bits approach, let me update that part of the patch.

You can add the changes to fields, but don't add the rldicXXX changes
in ppc_assembler.py

Thanks, David

On Thu, Aug 11, 2011 at 4:32 PM, Sven Hager
<sven.ha...@uni-duesseldorf.de> wrote:
> On 08/11/2011 09:42 PM, David Edelsohn wrote:
>>
>> Attached is a new patch that corrects the PPC fields.
>>
>> The only simple way I can think of handling the 64 bit immediate shift
>> field is by adding a keyword argument to Field to ignore overlap.
>> Expressing the details of the field splitting will be complicated and
>> doesn't seem worth it.
>>
>> Is there a preference for the current patch that explicitly performs
>> the conversion or a new argument to ignore overlap?
>>
>> Thanks, David
>
> Hello David,
>
> I think it is okay to add an attribute to class Field which
> explicitly allows overlapping bits. It is very easy to adapt
> the existing code in form.py to this.
>
> I will add your changes tomorrow.
>
> Best regards,
> Sven
>
_______________________________________________
pypy-dev mailing list
pypy-dev@python.org
http://mail.python.org/mailman/listinfo/pypy-dev

Reply via email to