On Mon, Jun 18, 2012 at 10:41 PM, Костя Лопухин <[email protected]>wrote:
> Please see pull request - not sure if I should have added test in > lib-python, because it tests the same thing, and is harder to run? > > https://bitbucket.org/pypy/pypy/pull-request/69/fix-issue-1180-implement-bool-formatting > > 2012/6/18 Костя Лопухин <[email protected]>: > > Ah, I see, thank you! I tried added a test to > > lib-python/2.7/test/test_bool.py, but could not run it using > > untranslated pypy > > > > 2012/6/18 Armin Rigo <[email protected]>: > >> Hi Konstantin, > >> > >> On Mon, Jun 18, 2012 at 3:19 PM, Костя Лопухин < > [email protected]> wrote: > >>> May I try? :) > >> > >> Sure :-) A first quick remark: you should add a test in pypy's own > >> tests, in pypy/objspace/std/test/test_newformat.py. Then run it with > >> "python pytest.py pypy/obj.../test_newformat.py". In this way, you > >> see the failing test and your fixes immediately, without needing to > >> wait for a complete translation. > >> > >> > >> A bientôt, > >> > >> Armin. > Hi Kostia You should not add tests to lib-python, unless you're going to submit patches to cpython anyway. It seems that you should make simpler tests (as in there is no need for self.s and self.b I think, why not use str and bool builtins?)
_______________________________________________ pypy-dev mailing list [email protected] http://mail.python.org/mailman/listinfo/pypy-dev
