Hello,
I created a pull request for a fix for a failing json test in the
stdlib-2.7.5 branch. This is my first pull request outside of a PyCon
sprint. When at a sprint, I either put the name of the PyPy developer
that had coached me in the reviewer field of the pull request, or asked
them for a suggestion for a reviewer. So for that first patch outside of
a PyPy sprint, I'm not quite sure what the right procedure is... What
should I do in the future to get code reviews for my pull requests.
Should I "just wait and someone will get to it (eventually)", or would
it be better to ping people a bit more explicitly?
Here is the pull request:
https://bitbucket.org/pypy/pypy/pull-request/192/fix-for-failing-json-test/diff
Also, any reason why buildbot isn't running automatically on the
stdlib-2.7.5 branch? The last run was on August 31st. This is the branch
which, once all tests pass, will be merged back into the trunk and then
the next release of PyPy will be announced as supporting CPython 2.7.5,
right? (Just making sure...) Assuming that's true, I'll work slowly on
making all the tests pass, assuming nobody beats me to it.
Thanks,
Christian
_______________________________________________
pypy-dev mailing list
[email protected]
https://mail.python.org/mailman/listinfo/pypy-dev
