Hi Anto, Yes, I ran your benchmarks and they are improved, particularly the ones that pass arguments. I need to rerun them now that I merged default. However, I would prefer it if we could find a real life cpyext benchmark (maybe using numpy?).
Cheers, Carl Friedrich Carl Friedrich On January 31, 2018 1:16:15 PM GMT+01:00, Antonio Cuni <anto.c...@gmail.com> wrote: >Hi Carl, >wow, this looks awesome. Did you run benchmarks to measure the speedup? >If >yes, should we add them to my repo? >https://github.com/antocuni/cpyext-benchmarks > >ciao, >Anto > >On Tue, Jan 30, 2018 at 1:31 PM, cfbolz <pypy.comm...@gmail.com> wrote: > >> Author: Carl Friedrich Bolz-Tereick <cfb...@gmx.de> >> Branch: cpyext-faster-arg-passing >> Changeset: r93724:627a1425607c >> Date: 2018-01-30 14:30 +0100 >> http://bitbucket.org/pypy/pypy/changeset/627a1425607c/ >> >> Log: document branch >> >> diff --git a/pypy/doc/whatsnew-head.rst b/pypy/doc/whatsnew-head.rst >> --- a/pypy/doc/whatsnew-head.rst >> +++ b/pypy/doc/whatsnew-head.rst >> @@ -23,3 +23,11 @@ >> added, then the performance using mapdict is linear in the number of >> attributes. This is now fixed (by switching to a regular dict after >80 >> attributes). >> + >> + >> +.. branch: cpyext-faster-arg-passing >> + >> +When using cpyext, improve the speed of passing certain objects from >PyPy >> to C >> +code, most notably None, True, False, types, all instances of >C-defined >> types. >> +Before, a dict lookup was needed every time such an object crossed >over, >> now it >> +is just a field read. >> _______________________________________________ >> pypy-commit mailing list >> pypy-com...@python.org >> https://mail.python.org/mailman/listinfo/pypy-commit >>
_______________________________________________ pypy-dev mailing list pypy-dev@python.org https://mail.python.org/mailman/listinfo/pypy-dev
