Hi Phil,

sorry for the delay..

Am Montag, 20. Juli 2009 schrieb Phil Thompson:
> On Sun, 19 Jul 2009 18:35:24 +0200, "Hans-Peter Jansen" <h...@urpla.net>
>
> wrote:
> > Hi Phil,
> >
> > after updating to 4.5.2, I suffer from a new issue, which is rather
>
> basic.
>
> > According to the changelog, you modified QVariant to not accept None
> > anymore, but would accept None directly, where a QVariant is expected.
>
> This
>
> > is unfortunate, since it breaks my code, but anyway, the second term
> > does
> >
> > not apply to QSettings.value() at least:
> >>>> from PyQt4 import QtCore
> >>>> settings = QtCore.QSettings()
> >>>> settings.value("xxx", None)
> >
> > Traceback (most recent call last):
> >   File "<stdin>", line 1, in <module>
> > TypeError: argument 2 of QSettings.value() has an invalid type
> >
> >
> > probably due to the const'ness of the 2nd QVariant.
> >
> > Is there any grave technical reason to not support the QVariant(None)
> > anymore? I was so convenient to use a special cased None and and having
> > a
> >
> > way to differentiate it with say, empty strings, empty somethings...
>
> Both issues should be fixed in *current* SIP and PyQt snapshots.
>
> The behaviour is slightly different. Before, None was wrapped as a valid
> QVariant which was unwrapped by toPyObject(). Now, None is converted to
> an invalid QVariant which is converted back to None by toPyObject().
> Hopefully you won't notice the difference.

No, that's fine with me, as long I get back what I stick into ;-) 

> If you can confirm you have no remaining problems I'll make a new release
> in a day or two.

Confirmed, all is well now. 

While at it, I noticed, that SUSE applies two patches to PyQt. Both 
attached. While the disable-rpath patch is more of a distribution policy, 
it may be worth an command line option, but the second is useful in general 
I think, as long as some check for the existence of python-config is added. 
What do you think?

Thanks a lot,

Pete
--- qpy/QtDesigner/qpydesigner.pro	2009/05/17 08:37:22	1.1
+++ qpy/QtDesigner/qpydesigner.pro	2009/05/17 08:37:50
@@ -35,6 +35,7 @@
 
 
 CONFIG      += designer static plugin
+CONFIG      -= rpath_libdirs
 TARGET      = qpydesigner
 TEMPLATE    = lib
 
--- designer/python.pro-in
+++ designer/python.pro-in
@@ -1,4 +1,5 @@
 CONFIG      += designer plugin release warn
+CONFIG      -= rpath_libdirs
 TARGET      = pythonplugin
 TEMPLATE    = lib
 
Index: PyQt-x11-gpl-4.4.4/configure.py
===================================================================
--- PyQt-x11-gpl-4.4.4.orig/configure.py
+++ PyQt-x11-gpl-4.4.4/configure.py
@@ -983,6 +983,8 @@ def add_makefile_extras(makefile, extra_
     if extra_libs:
         makefile.extra_libs.extend(extra_libs)
 
+    for lib in os.popen("python-config --libs").read().split():
+        makefile.extra_libs.append(lib.replace('-l', ''))
 
 def check_vendorid():
     """See if the VendorID library and include file can be found.
_______________________________________________
PyQt mailing list    PyQt@riverbankcomputing.com
http://www.riverbankcomputing.com/mailman/listinfo/pyqt

Reply via email to