Hi,
I have two patches that I would like to share in case others have been
having same issues compiling PySide that I did (while packaging PySide for
openSUSE).
* Backward compatibility with older cmake versions[1]
Older cmake versions than 2.6.4 (at least) seem not to support
multiple conditions in an 'if', making PySide compilation fails right
start. This patch basically splits them off in multiple 'if's.
Example: cmake version shipped on <= openSUSE 11.1 is older enough.
* Use ${CMAKE_ROOT} to better cross-distro independency[2]
data/CMakeLists.txt (lines 6-7):
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/FindPySide.cmake
DESTINATION share/cmake-2.6/Modules)
As you can see if a distro has changed its cmake directory to
something else users would have two different cmake directories.
To avoid this ${CMAKE_ROOT} should be used instead of hardcoding the
path location of cmake. Thus, it should be:
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/FindPySide.cmake
DESTINATION ${CMAKE_ROOT}/Modules)
Example: on openSUSE cmake path is /usr/share/cmake/ and not
/usr/share/cmake-2.6/ as hardcoded. ${CMAKE_ROOT} will take care of that.
Note: please note that while the first patch is not required to be
applied to PySide tree, the second one though should be applied imo for the
reason I've described above.
[1]
http://qt.gitorious.org/~cgoncalves/pyside/cgoncalves-pyside/commit/292aa22b8ded1ade3180da892afc21310cf98012
[2]
http://qt.gitorious.org/~cgoncalves/pyside/cgoncalves-pyside/commit/4ea5370c960d938dd864cf2c4a3449d83a7d2b60
--
Regards,
Carlos Gonçalves
_______________________________________________
PySide mailing list
[email protected]
http://lists.openbossa.org/listinfo/pyside
