Branch: refs/heads/master
Home: https://github.com/pytest-dev/pytest
Commit: 82a7ca96152b9b17285fcffc70cc88d5df7990a6
https://github.com/pytest-dev/pytest/commit/82a7ca96152b9b17285fcffc70cc88d5df7990a6
Author: Bruno Oliveira <[email protected]>
Date: 2018-08-27 (Mon, 27 Aug 2018)
Changed paths:
A changelog/3506.bugfix.rst
M src/_pytest/assertion/rewrite.py
M testing/test_assertrewrite.py
Log Message:
-----------
Avoid possible infinite recursion when writing pyc files in assert rewrite
What happens is that atomic_write on Python 2.7 on Windows will try
to convert the paths to unicode, but this triggers the import of
the encoding module for the file system codec, which in turn triggers
the rewrite, which in turn again tries to import the module, and so on.
This short-circuits the cases where we try to import another file when
writing a pyc file; I don't expect this to affect anything because
the only modules that could be affected are those imported by
atomic_writes.
Fix #3506
Commit: 10c1c7c41aec6d123cf97e3be38a4afccd99899a
https://github.com/pytest-dev/pytest/commit/10c1c7c41aec6d123cf97e3be38a4afccd99899a
Author: Bruno Oliveira <[email protected]>
Date: 2018-08-28 (Tue, 28 Aug 2018)
Changed paths:
A changelog/3506.bugfix.rst
M src/_pytest/assertion/rewrite.py
M testing/test_assertrewrite.py
Log Message:
-----------
Merge pull request #3895 from nicoddemus/issue-3506
Avoid possible infinite recursion when writing pyc files in assert rewrite
Compare:
https://github.com/pytest-dev/pytest/compare/16f452ef9866...10c1c7c41aec
**NOTE:** This service has been marked for deprecation:
https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
_______________________________________________
pytest-commit mailing list
[email protected]
https://mail.python.org/mailman/listinfo/pytest-commit
