On 1/10/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: > On 1/10/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: > > On 1/10/07, Collin Winter <[EMAIL PROTECTED]> wrote: > > > On 1/10/07, Neal Norwitz <[EMAIL PROTECTED]> wrote: > > > > Did the import magic number get changed? That was the cause of my > > > > last crash in test_hotshot (not related to this though). > > > > > > I don't think so (at least, I didn't change it). > > > > Actually, Neal meant that if the bytecode changed, you *should* have > > changed the magic number (and I should have remembered when I reviewed > > it). If the magic number doesn't change, bogus bytecode compiled by a > > previous version of the compiler may survive and throw things off. > > > > It looks as if the hotshot test passes after a "make clean" which is > > another indication that this is indeed the cause of the failure. > > (Still waiting to verify this result on a much slower machine where > > the same thing happened.) > > It passes there too now, but I'm confused as to whether the magic > number shuold be changed. Since not too many people ought to be > affected I'm tempted to forget about the whole episode...
I thought the magic number was only supposed to change when someone changes what the bytecode actually does (as opposed to changing what bytecode is generated)? Thanks, Collin Winter _______________________________________________ Python-3000 mailing list [email protected] http://mail.python.org/mailman/listinfo/python-3000 Unsubscribe: http://mail.python.org/mailman/options/python-3000/archive%40mail-archive.com
