Senthil Kumaran <orsent...@gmail.com> added the comment: Here are couple of Review Comments on What's new document.
1. The logging dictConfig example fails if you try directly out-of-text. The conf file is opened as a 'rb' and json module throws an error as "TypeError: can't use a string pattern on a bytes-like object". Suggestion - Just reading it as string is fine. Also, this example throws another error from json, when you read it as string. ValueError: Expecting property name: line 4 column 17 (char 204) I was able to fix it by simplifying the conf.json, but I think the current one itself should be fixed and made to work. Related suggestion - I see another section on logging further down. It would be better to combine the sections. 2.Issue number for functools.lru_cache is not mentioned. If no tracker id/ discussion is available, checkin link can be mentioned. 3. There is section for Popen which says, subprocess.Popen() functions now support with statements for auto-closing of the file descriptors. Not really. Only os.popen() function supports it. 4. In the concurrent.futures example, it is given as: import threading, shutil with threading.ThreadPoolExecutor(max_workers=4) as e: It should be: import concurrent.futures, shutil with concurrent.futures.ThreadPoolExector(max_workers=4) as e: Please correct these before the release on 19th. ---------- nosy: +orsenthil _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue11071> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
