Giampaolo Rodola' <g.rod...@gmail.com> added the comment:
Follow my comments:
> + source_address=('', 0)):
Make that default to None instead and pass it as-is to
socket.create_connection().
> + self.source_address = source_address
There's no need to store the source address as an instance attribute.
Just pass it as-is to socket.create_connection() in __init__ and connect
methods and then get rid of it.
I think source_address no longer makes sense in UNIX sockets / LMTP class.
Or at least, this is what I get if I try to bind() a UNIX socket:
>>> import socket
>>> sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
>>> sock.bind(("", 0))
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "<string>", line 1, in bind
TypeError: argument must be string or read-only character buffer, not tuple
>>>
----------
_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue11281>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
