Antoine Pitrou <pit...@free.fr> added the comment: Since the patch makes BadGzipFile a subclass of IOError, it doesn't look unreasonable. Some nits: - a gzipped file is not an "archive" - the unit tests should use either the "with" statement, or try/finally blocks to properly close the file even when the test fails - you should probably explicitly test that BadGzipFile is a subclass of IOError
---------- nosy: +pitrou _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue6584> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
