Éric Araujo <mer...@netwok.org> added the comment:

Looks great, thank you.  I think I’ll also add a docstring to main before 
committing, now that the function is publicly documented.

Did you have to manually click “Create Patch” to make roundup generate it?  Did 
you try first to click on the button of the existing repo before adding a new 
repo entry?  (Still learning how to use it, thanks for experimenting along :)

Brett: Thanks for the review.  If you don’t comment negatively on the doc 
change, I will commit this.

(Side concern: the module does not define __all__, even though only 4 functions 
and 4 constants are officially documented.  I’d like to define __all__, but the 
recentish huge thread on public/private APIs scared me.)

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue11591>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to