Éric Araujo <[email protected]> added the comment:
I’m probably the one with the least regrtest knowledge among us, but I like the
general idea of moving the compat info from one huge dict into the tests
themselves. It looks more readable and maintainable.
The new tests for test.support looks good.
I have a reputation to maintain, so here are some nits:
- “FS encoding” would be clearer as “filesystem encoding”.
- The argument names “required_on” and “optional” are not symmetrical.
- The indentation is hard to read here:
+pty = import_module('pty',
+ optional=['win32', 'os2emx', 'freebsd4', 'freebsd5', 'freebsd6',
+ 'freebsd7', 'freebsd8'])
----------
nosy: +eric.araujo
_______________________________________
Python tracker <[email protected]>
<http://bugs.python.org/issue10966>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
