Torsten Becker <torsten.bec...@gmail.com> added the comment: > I got your comments, Torsten. I finds funny too that the tracker is > not notified. > I wrote new comments too, but not using "the right way", so now I am > the one not sure you got them... :-)
That time I actually got a separate mail. :) > Better to have a 3.1/2.7 patch. The current workflow requires to > patch the old version first (3.1), and up-port the change to 3.2 and > 3.3. > So, 2.7 and 3.1 would be more useful. Al least if the patch applies > to 3.2 and 3.3 easily. If major surgery is needed, let me know. I uploaded an improved v4 patch against 2.7 and 3.1. patch does not apply it cleanly in the 3.2 and 3.3 branches, though. This is mostly because Objects/stringlib/find.h has changed too much and the #define STRINGLIB_IS_UNICODE (3.3, 3.2) is called FROM_UNICODE in 3.1. The other files work fine. It should be no problem to merge this up by hand, though. > PS: If you use mercurial, try to upload the patch directly from it. > See the "Remote hg repo" box. I'm using Mercurial, but unfortunately hg hangs forever when trying to push to bitbucket, so I am just sticking with patches for now. ---------- Added file: http://bugs.python.org/file21655/issue-11828-v4-3.1.patch _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue11828> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
