Prashant Kumar <contactprashan...@gmail.com> added the comment:

I made changes in manifest.py which can be viewed here: 
https://bitbucket.org/pkumar/distutils2_bugs/changeset/111c1253ea7a

I'm not sure if I should modify test_command_sdist.py for the failing tests of 
manifest contents(since it is mentioned not to edit). 

msg133834:
>> I don’t understand this comment: “Though, inside zip-file we get files 
>> without its parent dir, nothing changes in manifest file(should it change?)

code from test_command_sdist.py:

        zip_file = zipfile.ZipFile(join(dist_folder, 'fake-1.0.zip'))
        try:
            content = zip_file.namelist()
        finally:
            zip_file.close()
after the change as mentioned in msg127191, the value of content changed, i.e. 
'fake-1.0/some/other_file.txt' was changed to 'fake-1.0/other_file.txt'.But 
modifications were still required for the manifest. Above change should serve 
the purpose, I guess.

----------
hgrepos: +20

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue10932>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to