Antoine Pitrou <pit...@free.fr> added the comment:

Comments:
- I don't like the fact that skip_unless_cjson() uses unittest internals. Why 
can't you write something like:
   skip_unless_cjson = skipUnless(...)

- instead of "self.mod", "self.json" would be nicer

- you could also export "self.loads", "self.dumps" for easier access

- you could also have two base classes exporting all this instead of repeating 
the attribute-setting for every test class

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue5723>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to