Catalin Iacob <[email protected]> added the comment:
Attached v1 of patch. Please review.
There are some tests using GMail in test_smtpnet.py. They still pass with the
patch. I also did manual tests with GMail with both SMTP + starttls and
SMTP_SSL.
The idea of the patch is that SMTP.getreply is already doing:
if self.file is None:
self.file = self.sock.makefile('rb')
Therefore, the patch invalidates self.file by setting it to None every time
self.sock is (re-)assigned to something.
For consistency, setting self.file to None is also done in LMTP.connect when
setting self.sock to a Unix socket although it's not necessarily needed there.
Not doing this makes the following scenario fail: create an LMTP instance, call
connect, send and read some data (self.file gets initialized), call connect
again with an Unix socket, reading more data now uses self.file referring to
old socket. But I'm not sure if this scenario is a bug or a misuse of the API,
aka you shouldn't call connect twice on the same instance.
Note that I didn't test LMTP. Should I or is it obvious enough that the change
is ok?
----------
keywords: +patch
nosy: +catalin.iacob
Added file: http://bugs.python.org/file22171/remove_sslfakefile_v1.patch
_______________________________________
Python tracker <[email protected]>
<http://bugs.python.org/issue11893>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
