STINNER Victor <victor.stin...@haypocalc.com> added the comment: Comments on is_selectable.diff.
> +#define IS_SELECTABLE(s) (_PyIsSelectable_fd((s)->sock_fd) || > s->sock_timeout <= 0.0) You may add parenthesis around the second s (even if it's unrelated to this issue and not a regression of your patch). > +#ifdef Py_SOCKET_FD_CAN_BE_GE_FD_SETSIZE > ... > #if defined(_MSC_VER) > max = 0; /* not used for Win32 */ I still don't understand these checks: why not testing simply for #ifdef MS_WINDOWS? MinGW or Cygwin have another implementation of select() which is more limited? ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue12287> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
